Commit b4aa975c authored by Dafna Hirschfeld's avatar Dafna Hirschfeld Committed by Mauro Carvalho Chehab
Browse files

media: vimc: remove the helper function vimc_ent_sd_unregister 



since this function only calls v4l2_device_unregister_subdev,
it is pointless.

Signed-off-by: default avatarDafna Hirschfeld <dafna.hirschfeld@collabora.com>
Acked-by: default avatarHelen Koike <helen.koike@collabora.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
parent 9fb82aaa

drivers/media/platform/vimc/vimc-common.c

+0 −5
Original line number Diff line number Diff line
@@ -421,8 +421,3 @@ int vimc_ent_sd_register(struct vimc_ent_device *ved, 
}

EXPORT_SYMBOL_GPL(vimc_ent_sd_register);

void vimc_ent_sd_unregister(struct vimc_ent_device *ved, struct v4l2_subdev *sd)

{

	v4l2_device_unregister_subdev(sd);

}

EXPORT_SYMBOL_GPL(vimc_ent_sd_unregister);

drivers/media/platform/vimc/vimc-common.h

+0 −12
Original line number Diff line number Diff line
@@ -251,18 +251,6 @@ int vimc_ent_sd_register(struct vimc_ent_device *ved, 
			 const struct v4l2_subdev_internal_ops *sd_int_ops,

			 const struct v4l2_subdev_ops *sd_ops);



/**

 * vimc_ent_sd_unregister - cleanup and unregister a subdev node

 *

 * @ved:	the vimc_ent_device struct to be cleaned up

 * @sd:		the v4l2_subdev struct to be unregistered

 *

 * Helper function cleanup and unregister the struct vimc_ent_device and struct

 * v4l2_subdev which represents a subdev node in the topology

 */

void vimc_ent_sd_unregister(struct vimc_ent_device *ved,

			    struct v4l2_subdev *sd);



/**

 * vimc_link_validate - validates a media link

 *

drivers/media/platform/vimc/vimc-debayer.c

+1 −1
Original line number Diff line number Diff line
@@ -491,7 +491,7 @@ void vimc_deb_rm(struct vimc_device *vimc, struct vimc_ent_device *ved) 
	struct vimc_deb_device *vdeb;



	vdeb = container_of(ved, struct vimc_deb_device, ved);

	vimc_ent_sd_unregister(ved, &vdeb->sd);

	v4l2_device_unregister_subdev(&vdeb->sd);

}



struct vimc_ent_device *vimc_deb_add(struct vimc_device *vimc,

drivers/media/platform/vimc/vimc-scaler.c

+1 −1
Original line number Diff line number Diff line
@@ -350,7 +350,7 @@ void vimc_sca_rm(struct vimc_device *vimc, struct vimc_ent_device *ved) 
	struct vimc_sca_device *vsca;



	vsca = container_of(ved, struct vimc_sca_device, ved);

	vimc_ent_sd_unregister(ved, &vsca->sd);

	v4l2_device_unregister_subdev(&vsca->sd);

}



struct vimc_ent_device *vimc_sca_add(struct vimc_device *vimc,

drivers/media/platform/vimc/vimc-sensor.c

+1 −1
Original line number Diff line number Diff line
@@ -305,7 +305,7 @@ void vimc_sen_rm(struct vimc_device *vimc, struct vimc_ent_device *ved) 
	struct vimc_sen_device *vsen;



	vsen = container_of(ved, struct vimc_sen_device, ved);

	vimc_ent_sd_unregister(ved, &vsen->sd);

	v4l2_device_unregister_subdev(&vsen->sd);

}



/* Image Processing Controls */