Commit b471927e authored by Boqun Feng's avatar Boqun Feng Committed by Miguel Ojeda
Browse files

kallsyms: avoid hardcoding buffer size 



This introduces `KSYM_NAME_LEN_BUFFER` in place of the previously
hardcoded size of the input buffer.

It will also make it easier to update the size in a single place
in a later patch.

Reviewed-by: default avatarKees Cook <keescook@chromium.org>
Reviewed-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarBoqun Feng <boqun.feng@gmail.com>
Co-developed-by: default avatarMiguel Ojeda <ojeda@kernel.org>
Signed-off-by: default avatarMiguel Ojeda <ojeda@kernel.org>
parent b66c874f

scripts/kallsyms.c

+8 −2
Original line number Diff line number Diff line
@@ -27,8 +27,14 @@ 


#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof(arr[0]))



#define _stringify_1(x)	#x

#define _stringify(x)	_stringify_1(x)



#define KSYM_NAME_LEN		128



/* A substantially bigger size than the current maximum. */

#define KSYM_NAME_LEN_BUFFER	499



struct sym_entry {

	unsigned long long addr;

	unsigned int len;
@@ -198,13 +204,13 @@ static void check_symbol_range(const char *sym, unsigned long long addr, 


static struct sym_entry *read_symbol(FILE *in)

{

	char name[500], type;

	char name[KSYM_NAME_LEN_BUFFER+1], type;

	unsigned long long addr;

	unsigned int len;

	struct sym_entry *sym;

	int rc;



	rc = fscanf(in, "%llx %c %499s\n", &addr, &type, name);

	rc = fscanf(in, "%llx %c %" _stringify(KSYM_NAME_LEN_BUFFER) "s\n", &addr, &type, name);

	if (rc != 3) {

		if (rc != EOF && fgets(name, ARRAY_SIZE(name), in) == NULL)

			fprintf(stderr, "Read error or end of file.\n");