Commit b46c760e authored by Niklas Cassel's avatar Niklas Cassel Committed by Damien Le Moal
Browse files

ata: libata: drop superfluous ata_eh_request_sense() parameter 



The parameter can easily be derived from struct ata_queued_cmd.

Signed-off-by: default avatarNiklas Cassel <niklas.cassel@wdc.com>
Signed-off-by: default avatarDamien Le Moal <damien.lemoal@opensource.wdc.com>
parent 630624cb

drivers/ata/libata-eh.c

+3 −4
Original line number Diff line number Diff line
@@ -1390,7 +1390,6 @@ unsigned int atapi_eh_tur(struct ata_device *dev, u8 *r_sense_key) 
/**

 *	ata_eh_request_sense - perform REQUEST_SENSE_DATA_EXT

 *	@qc: qc to perform REQUEST_SENSE_SENSE_DATA_EXT to

 *	@cmd: scsi command for which the sense code should be set

 *

 *	Perform REQUEST_SENSE_DATA_EXT after the device reported CHECK

 *	SENSE.  This function is an EH helper.
@@ -1398,9 +1397,9 @@ unsigned int atapi_eh_tur(struct ata_device *dev, u8 *r_sense_key) 
 *	LOCKING:

 *	Kernel thread context (may sleep).

 */

static void ata_eh_request_sense(struct ata_queued_cmd *qc,

				 struct scsi_cmnd *cmd)

static void ata_eh_request_sense(struct ata_queued_cmd *qc)

{

	struct scsi_cmnd *cmd = qc->scsicmd;

	struct ata_device *dev = qc->dev;

	struct ata_taskfile tf;

	unsigned int err_mask;
@@ -1576,7 +1575,7 @@ static unsigned int ata_eh_analyze_tf(struct ata_queued_cmd *qc, 
	switch (qc->dev->class) {

	case ATA_DEV_ZAC:

		if (stat & ATA_SENSE)

			ata_eh_request_sense(qc, qc->scsicmd);

			ata_eh_request_sense(qc);

		fallthrough;

	case ATA_DEV_ATA:

		if (err & ATA_ICRC)