Commit b4646da0 authored by Shay Drory's avatar Shay Drory Committed by Saeed Mahameed
Browse files

net/mlx5: SF, Drain health before removing device 



There is no point in recovery during device removal. Also, if health
work started need to wait for it to avoid races and NULL pointer
access.

Hence, drain health WQ before removing device.

Fixes: 1958fc2f ("net/mlx5: SF, Add auxiliary device driver")
Signed-off-by: default avatarShay Drory <shayd@nvidia.com>
Reviewed-by: default avatarMoshe Shemesh <moshe@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent 824c8dc4

drivers/net/ethernet/mellanox/mlx5/core/sf/dev/driver.c

+1 −0
Original line number Diff line number Diff line
@@ -63,6 +63,7 @@ static void mlx5_sf_dev_remove(struct auxiliary_device *adev) 
	struct mlx5_sf_dev *sf_dev = container_of(adev, struct mlx5_sf_dev, adev);

	struct devlink *devlink = priv_to_devlink(sf_dev->mdev);



	mlx5_drain_health_wq(sf_dev->mdev);

	devlink_unregister(devlink);

	mlx5_uninit_one(sf_dev->mdev);

	iounmap(sf_dev->mdev->iseg);