Commit b4443c17 authored by Masami Hiramatsu's avatar Masami Hiramatsu Committed by Steven Rostedt (VMware)
Browse files

tracing/probe: Check the size of argument name and body 

Check the size of argument name and expression is not 0
and smaller than maximum length.

Link: http://lkml.kernel.org/r/155253783029.14922.12650939303827581096.stgit@devnote2



Signed-off-by: default avatarMasami Hiramatsu <mhiramat@kernel.org>
Signed-off-by: default avatarSteven Rostedt (VMware) <rostedt@goodmis.org>
parent dec65d79

kernel/trace/trace_probe.c

+2 −0
Original line number Diff line number Diff line
@@ -554,6 +554,8 @@ int traceprobe_parse_probe_arg(struct trace_probe *tp, int i, char *arg, 


	body = strchr(arg, '=');

	if (body) {

		if (body - arg > MAX_ARG_NAME_LEN || body == arg)

			return -EINVAL;

		parg->name = kmemdup_nul(arg, body - arg, GFP_KERNEL);

		body++;

	} else {

kernel/trace/trace_probe.h

+1 −0
Original line number Diff line number Diff line
@@ -32,6 +32,7 @@ 
#define MAX_TRACE_ARGS		128

#define MAX_ARGSTR_LEN		63

#define MAX_ARRAY_LEN		64

#define MAX_ARG_NAME_LEN	32

#define MAX_STRING_SIZE		PATH_MAX



/* Reserved field names */