Commit b43c75ab authored by Dinghao Liu's avatar Dinghao Liu Committed by David S. Miller
Browse files

rxrpc: Fix memory leak in rxkad_verify_response() 



Fix a memory leak in rxkad_verify_response() whereby the response buffer
doesn't get freed if we fail to allocate a ticket buffer.

Fixes: ef68622d ("rxrpc: Handle temporary errors better in rxkad security")
Signed-off-by: default avatarDinghao Liu <dinghao.liu@zju.edu.cn>
Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 8d73a73a

net/rxrpc/rxkad.c

+2 −1
Original line number Diff line number Diff line
@@ -1137,7 +1137,7 @@ static int rxkad_verify_response(struct rxrpc_connection *conn, 
	ret = -ENOMEM;

	ticket = kmalloc(ticket_len, GFP_NOFS);

	if (!ticket)

		goto temporary_error;

		goto temporary_error_free_resp;



	eproto = tracepoint_string("rxkad_tkt_short");

	abort_code = RXKADPACKETSHORT;
@@ -1230,6 +1230,7 @@ static int rxkad_verify_response(struct rxrpc_connection *conn, 


temporary_error_free_ticket:

	kfree(ticket);

temporary_error_free_resp:

	kfree(response);

temporary_error:

	/* Ignore the response packet if we got a temporary error such as