Commit b419b65f authored by Chris Mi's avatar Chris Mi Committed by Jialin Zhang
Browse files

RDMA/mlx5: Set local port to one when accessing counters 

stable inclusion
from stable-v5.10.143
commit a00b1b10e0a60474c2a60ef84f4d4736f7051535
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I6D0U6

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=a00b1b10e0a60474c2a60ef84f4d4736f7051535



--------------------------------

[ Upstream commit 74b30b3a ]

When accessing Ports Performance Counters Register (PPCNT),
local port must be one if it is Function-Per-Port HCA that
HCA_CAP.num_ports is 1.

The offending patch can change the local port to other values
when accessing PPCNT after enabling switchdev mode. The following
syndrome will be printed:

 # cat /sys/class/infiniband/rdmap4s0f0/ports/2/counters/*
 # dmesg
 mlx5_core 0000:04:00.0: mlx5_cmd_check:756:(pid 12450): ACCESS_REG(0x805) op_mod(0x1) failed, status bad parameter(0x3), syndrome (0x1e5585)

Fix it by setting local port to one for Function-Per-Port HCA.

Fixes: 210b1f78 ("IB/mlx5: When not in dual port RoCE mode, use provided port as native")
Reviewed-by: default avatarMark Bloch <mbloch@nvidia.com>
Signed-off-by: default avatarChris Mi <cmi@nvidia.com>
Link: https://lore.kernel.org/r/6c5086c295c76211169e58dbd610fb0402360bab.1661763459.git.leonro@nvidia.com


Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarJialin Zhang <zhangjialin11@huawei.com>
Reviewed-by: default avatarZheng Zengkai <zhengzengkai@huawei.com>
parent febc1bc2

drivers/infiniband/hw/mlx5/mad.c

+6 −0
Original line number Diff line number Diff line
@@ -166,6 +166,12 @@ static int process_pma_cmd(struct mlx5_ib_dev *dev, u8 port_num, 
		mdev = dev->mdev;

		mdev_port_num = 1;

	}

	if (MLX5_CAP_GEN(dev->mdev, num_ports) == 1) {

		/* set local port to one for Function-Per-Port HCA. */

		mdev = dev->mdev;

		mdev_port_num = 1;

	}



	/* Declaring support of extended counters */

	if (in_mad->mad_hdr.attr_id == IB_PMA_CLASS_PORT_INFO) {

		struct ib_class_port_info cpi = {};