Commit b40887e1 authored Oct 16, 2021 by Chuck Lever Committed by Trond Myklebust Oct 20, 2021

SUNRPC: Trace calls to .rpc_call_done

Introduce a single tracepoint that can replace simple dprintk call
sites in upper layer "rpc_call_done" callbacks. Example:

kworker/u24:2-1254 [001] 771.026677: rpc_stats_latency: task:00000001@00000002 xid=0x16a6f3c0 rpcbindv2 GETPORT backlog=446 rtt=101 execute=555
kworker/u24:2-1254 [001] 771.026677: rpc_task_call_done: task:00000001@00000002 flags=ASYNC|DYNAMIC|SOFT|SOFTCONN|SENT runstate=RUNNING|ACTIVE status=0 action=rpcb_getport_done
kworker/u24:2-1254 [001] 771.026678: rpcb_setport: task:00000001@00000002 status=0 port=20048

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>

parent d9f87743

fs/lockd/clntproc.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -794,9 +794,6 @@ static void nlmclnt_cancel_callback(struct rpc_task task, void data)
		goto retry_cancel;
		}

		dprintk("lockd: cancel status %u (task %u)\n",
		status, task->tk_pid);

		switch (status) {
		case NLM_LCK_GRANTED:
		case NLM_LCK_DENIED_GRACE_PERIOD:

fs/lockd/svc4proc.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -269,8 +269,6 @@ nlm4svc_proc_granted(struct svc_rqst *rqstp)
		*/
		static void nlm4svc_callback_exit(struct rpc_task task, void data)
		{
		dprintk("lockd: %5u callback returned %d\n", task->tk_pid,
		-task->tk_status);
		}

		static void nlm4svc_callback_release(void *data)

fs/lockd/svcproc.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -301,8 +301,6 @@ nlmsvc_proc_granted(struct svc_rqst *rqstp)
		*/
		static void nlmsvc_callback_exit(struct rpc_task task, void data)
		{
		dprintk("lockd: %5u callback returned %d\n", task->tk_pid,
		-task->tk_status);
		}

		void nlmsvc_release_call(struct nlm_rqst *call)

fs/nfs/filelayout/filelayout.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -293,8 +293,6 @@ static void filelayout_read_call_done(struct rpc_task task, void data)
		{
		struct nfs_pgio_header *hdr = data;

		dprintk("--> %s task->tk_status %d\n", __func__, task->tk_status);

		if (test_bit(NFS_IOHDR_REDO, &hdr->flags) &&
		task->tk_status == 0) {
		nfs41_sequence_done(task, &hdr->res.seq_res);

fs/nfs/flexfilelayout/flexfilelayout.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -1414,8 +1414,6 @@ static void ff_layout_read_call_done(struct rpc_task task, void data)
		{
		struct nfs_pgio_header *hdr = data;

		dprintk("--> %s task->tk_status %d\n", __func__, task->tk_status);

		if (test_bit(NFS_IOHDR_REDO, &hdr->flags) &&
		task->tk_status == 0) {
		nfs4_sequence_done(task, &hdr->res.seq_res);