Commit b4047aac authored by Jian Shen's avatar Jian Shen Committed by David S. Miller
Browse files

net: hns3: add check for HNS3_NIC_STATE_INITED in hns3_reset_notify_up_enet() 



In some cases, the device is not initialized because reset failed.
If another task calls hns3_reset_notify_up_enet() before reset
retry, it will cause an error since uninitialized pointer access.
So add check for HNS3_NIC_STATE_INITED before calling
hns3_nic_net_open() in hns3_reset_notify_up_enet().

Fixes: bb6b94a8 ("net: hns3: Add reset interface implementation in client")
Signed-off-by: default avatarJian Shen <shenjian15@huawei.com>
Signed-off-by: default avatarHuazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 568a54bd

drivers/net/ethernet/hisilicon/hns3/hns3_enet.c

+5 −0
Original line number Diff line number Diff line
@@ -4616,6 +4616,11 @@ static int hns3_reset_notify_up_enet(struct hnae3_handle *handle) 
	struct hns3_nic_priv *priv = netdev_priv(kinfo->netdev);

	int ret = 0;



	if (!test_bit(HNS3_NIC_STATE_INITED, &priv->state)) {

		netdev_err(kinfo->netdev, "device is not initialized yet\n");

		return -EFAULT;

	}



	clear_bit(HNS3_NIC_STATE_RESETTING, &priv->state);



	if (netif_running(kinfo->netdev)) {