Commit b3f4b679 authored by Jiapeng Chong's avatar Jiapeng Chong Committed by Lee Jones
Browse files

leds: flash: leds-qcom-flash: Fix an unsigned comparison which can never be negative 



The variable 'count' is defined as unsigned type, so the following if
statement is invalid, we can modify the type of count to int.

if (count <= 0) {
	dev_err(dev, "No led-sources specified\n");
	return -ENODEV;
}

./drivers/leds/flash/leds-qcom-flash.c:546:5-10: WARNING: Unsigned expression compared with zero: count <= 0.

Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5344


Signed-off-by: default avatarJiapeng Chong <jiapeng.chong@linux.alibaba.com>
Signed-off-by: default avatarLee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20230531053559.5702-1-jiapeng.chong@linux.alibaba.com
parent dda96847

drivers/leds/flash/leds-qcom-flash.c

+2 −2
Original line number Diff line number Diff line
@@ -538,9 +538,9 @@ static int qcom_flash_register_led_device(struct device *dev, 
	struct led_init_data init_data;

	struct led_classdev_flash *flash = &led->flash;

	struct led_flash_setting *brightness, *timeout;

	u32 count, current_ua, timeout_us;

	u32 current_ua, timeout_us;

	u32 channels[4];

	int i, rc;

	int i, rc, count;



	count = fwnode_property_count_u32(node, "led-sources");

	if (count <= 0) {