Commit b3cc73d2 authored by Sakari Ailus's avatar Sakari Ailus Committed by Mauro Carvalho Chehab
Browse files

media: v4l2-fwnode: v4l2_fwnode_endpoint_parse caller must init vep argument 



Document that the caller of v4l2_fwnode_endpoint_parse() must init the
fields of struct v4l2_fwnode_endpoint (vep argument) fields.

It used to be that the fields were zeroed by v4l2_fwnode_endpoint_parse
when bus type was set to V4L2_MBUS_UNKNOWN but with recent changes (Fixes:
line below) that no longer makes sense.

Fixes: bb4bba92 ("media: v4l2-fwnode: Make bus configuration a struct")
Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: default avatarNiklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 1726b976

include/media/v4l2-fwnode.h

+6 −0
Original line number Diff line number Diff line
@@ -231,6 +231,9 @@ struct v4l2_fwnode_connector { 
 * guessing @vep.bus_type between CSI-2 D-PHY, parallel and BT.656 busses is

 * supported. NEVER RELY ON GUESSING @vep.bus_type IN NEW DRIVERS!

 *

 * The caller is required to initialise all fields of @vep, either with

 * explicitly values, or by zeroing them.

 *

 * The function does not change the V4L2 fwnode endpoint state if it fails.

 *

 * NOTE: This function does not parse properties the size of which is variable
@@ -273,6 +276,9 @@ void v4l2_fwnode_endpoint_free(struct v4l2_fwnode_endpoint *vep); 
 * guessing @vep.bus_type between CSI-2 D-PHY, parallel and BT.656 busses is

 * supported. NEVER RELY ON GUESSING @vep.bus_type IN NEW DRIVERS!

 *

 * The caller is required to initialise all fields of @vep, either with

 * explicitly values, or by zeroing them.

 *

 * The function does not change the V4L2 fwnode endpoint state if it fails.

 *

 * v4l2_fwnode_endpoint_alloc_parse() has two important differences to