Unverified Commit b3be4520 authored by Danilo Krummrich's avatar Danilo Krummrich Committed by Maxime Ripard
Browse files

drm/vc4: hvs: protect drm_print_regset32() 



In vc4_hvs_dump_state() potentially freed resources are protected from
being accessed with drm_dev_enter()/drm_dev_exit().

Also include drm_print_regset32() in the protected section, since
drm_print_regset32() does access memory that is typically mapped via
devm_* calls.

Fixes: 969cfae1 ("drm/vc4: hvs: Protect device resources after removal")
Signed-off-by: default avatarDanilo Krummrich <dakr@redhat.com>
Signed-off-by: default avatarMaxime Ripard <maxime@cerno.tech>
Link: https://lore.kernel.org/r/20220824161327.330627-5-dakr@redhat.com
parent e0c95303

drivers/gpu/drm/vc4/vc4_hvs.c

+2 −2
Original line number Diff line number Diff line
@@ -71,11 +71,11 @@ void vc4_hvs_dump_state(struct vc4_hvs *hvs) 
	struct drm_printer p = drm_info_printer(&hvs->pdev->dev);

	int idx, i;



	drm_print_regset32(&p, &hvs->regset);



	if (!drm_dev_enter(drm, &idx))

		return;



	drm_print_regset32(&p, &hvs->regset);



	DRM_INFO("HVS ctx:\n");

	for (i = 0; i < 64; i += 4) {

		DRM_INFO("0x%08x (%s): 0x%08x 0x%08x 0x%08x 0x%08x\n",