Commit b39f35eb authored by Yu Kuai's avatar Yu Kuai Committed by Song Liu
Browse files

md: don't quiesce in mddev_suspend() 



Some levels doesn't implement "pers->quiesce", for example
raid0_quiesce() is empty, and now that all levels will drop 'active_io'
until io is done, wait for 'active_io' to be 0 is enough to make sure all
normal io is done, and percpu_ref_kill() for 'active_io' will make sure
no new normal io can be dispatched. There is no need to call
"pers->quiesce" anymore from mddev_suspend().

Signed-off-by: default avatarYu Kuai <yukuai3@huawei.com>
Link: https://lore.kernel.org/r/20230628012931.88911-2-yukuai1@huaweicloud.com


Signed-off-by: default avatarSong Liu <song@kernel.org>
parent 02c67a3b

drivers/md/md.c

+0 −2
Original line number Diff line number Diff line
@@ -453,7 +453,6 @@ void mddev_suspend(struct mddev *mddev) 
		mddev->pers->prepare_suspend(mddev);



	wait_event(mddev->sb_wait, percpu_ref_is_zero(&mddev->active_io));

	mddev->pers->quiesce(mddev, 1);

	clear_bit_unlock(MD_ALLOW_SB_UPDATE, &mddev->flags);

	wait_event(mddev->sb_wait, !test_bit(MD_UPDATING_SB, &mddev->flags));
@@ -472,7 +471,6 @@ void mddev_resume(struct mddev *mddev) 
		return;

	percpu_ref_resurrect(&mddev->active_io);

	wake_up(&mddev->sb_wait);

	mddev->pers->quiesce(mddev, 0);



	set_bit(MD_RECOVERY_NEEDED, &mddev->recovery);

	md_wakeup_thread(mddev->thread);