Commit b39d8c41 authored by Vlad Buslov's avatar Vlad Buslov Committed by Jakub Kicinski
Browse files

selftests/tc-testing: Fix SFB db test 



Setting very small value of db like 10ms introduces rounding errors when
converting to/from jiffies on some kernel configs. For example, on 250hz
the actual value will be set to 12ms which causes the test to fail:

 # $ sudo ./tdc.py  -d eth2 -e 3410
 #  -- ns/SubPlugin.__init__
 # Test 3410: Create SFB with db setting
 #
 # All test results:
 #
 # 1..1
 # not ok 1 3410 - Create SFB with db setting
 #         Could not match regex pattern. Verify command output:
 # qdisc sfb 1: root refcnt 2 rehash 600s db 12ms limit 1000p max 25p target 20p increment 0.000503548 decrement 4.57771e-05 penalty_rate 10pps penalty_burst 20p

Set the value to 100ms instead which currently seem to work on 100hz,
250hz, 300hz and 1000hz kernel configs.

Fixes: 6ad92dc5 ("selftests/tc-testing: add selftests for sfb qdisc")
Signed-off-by: default avatarVlad Buslov <vladbu@nvidia.com>
Reviewed-by: default avatarPedro Tammela <pctammela@mojatatu.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent b849c566

tools/testing/selftests/tc-testing/tc-tests/qdiscs/sfb.json

+2 −2
Original line number Diff line number Diff line
@@ -58,10 +58,10 @@ 
        "setup": [

            "$IP link add dev $DUMMY type dummy || /bin/true"

        ],

        "cmdUnderTest": "$TC qdisc add dev $DUMMY handle 1: root sfb db 10",

        "cmdUnderTest": "$TC qdisc add dev $DUMMY handle 1: root sfb db 100",

        "expExitCode": "0",

        "verifyCmd": "$TC qdisc show dev $DUMMY",

        "matchPattern": "qdisc sfb 1: root refcnt [0-9]+ rehash 600s db 10ms",

        "matchPattern": "qdisc sfb 1: root refcnt [0-9]+ rehash 600s db 100ms",

        "matchCount": "1",

        "teardown": [

            "$TC qdisc del dev $DUMMY handle 1: root",