Commit b399b066 authored by Roi Dayan's avatar Roi Dayan Committed by Saeed Mahameed
Browse files

net/mlx5: Lag, Remove redundant bool allocation on the stack 



There is no need to allocate the bool variable and can just return the value.

Signed-off-by: default avatarRoi Dayan <roid@nvidia.com>
Reviewed-by: default avatarMaor Dickman <maord@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent 9a49a64e

drivers/net/ethernet/mellanox/mlx5/core/lag/mp.c

+2 −6
Original line number Diff line number Diff line
@@ -28,13 +28,9 @@ static bool mlx5_lag_multipath_check_prereq(struct mlx5_lag *ldev) 


bool mlx5_lag_is_multipath(struct mlx5_core_dev *dev)

{

	struct mlx5_lag *ldev;

	bool res;



	ldev = mlx5_lag_dev(dev);

	res  = ldev && __mlx5_lag_is_multipath(ldev);

	struct mlx5_lag *ldev = mlx5_lag_dev(dev);



	return res;

	return ldev && __mlx5_lag_is_multipath(ldev);

}



/**

drivers/net/ethernet/mellanox/mlx5/core/lag/mpesw.c

+1 −3
Original line number Diff line number Diff line
@@ -115,10 +115,8 @@ int mlx5_lag_mpesw_do_mirred(struct mlx5_core_dev *mdev, 
bool mlx5_lag_mpesw_is_activated(struct mlx5_core_dev *dev)

{

	struct mlx5_lag *ldev = mlx5_lag_dev(dev);

	bool ret;



	ret = ldev && ldev->mode == MLX5_LAG_MODE_MPESW;

	return ret;

	return ldev && ldev->mode == MLX5_LAG_MODE_MPESW;

}



void mlx5_lag_mpesw_init(struct mlx5_lag *ldev)