Commit b3880c69 authored by David Hildenbrand's avatar David Hildenbrand Committed by Linus Torvalds
Browse files

video: fbdev: acornfb: remove free_unused_pages() 

Patch series "mm: simplify free_highmem_page() and free_reserved_page()".

Let's simplify and unify free_highmem_page() and free_reserved_page().

This patch (of 2):

This function is never used and it is one of the last remaining user of
__free_reserved_page().  Let's just drop it.

Link: https://lkml.kernel.org/r/20210126182113.19892-1-david@redhat.com
Link: https://lkml.kernel.org/r/20210126182113.19892-2-david@redhat.com


Fixes: ffd29195 ("drivers/video/acornfb.c: remove dead code")
Signed-off-by: default avatarDavid Hildenbrand <david@redhat.com>
Reviewed-by: default avatarOscar Salvador <osalvador@suse.de>
Reviewed-by: default avatarAnshuman Khandual <anshuman.khandual@arm.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: "Peter Zijlstra (Intel)" <peterz@infradead.org>
Cc: Mike Rapoport <rppt@kernel.org>
Cc: Michal Hocko <mhocko@kernel.org>
Cc: Wei Yang <richard.weiyang@linux.alibaba.com>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 9699ee7b

drivers/video/fbdev/acornfb.c

+0 −34
Original line number Diff line number Diff line
@@ -921,40 +921,6 @@ static int acornfb_detect_monitortype(void) 
	return 4;

}



/*

 * This enables the unused memory to be freed on older Acorn machines.

 * We are freeing memory on behalf of the architecture initialisation

 * code here.

 */

static inline void

free_unused_pages(unsigned int virtual_start, unsigned int virtual_end)

{

	int mb_freed = 0;



	/*

	 * Align addresses

	 */

	virtual_start = PAGE_ALIGN(virtual_start);

	virtual_end = PAGE_ALIGN(virtual_end);



	while (virtual_start < virtual_end) {

		struct page *page;



		/*

		 * Clear page reserved bit,

		 * set count to 1, and free

		 * the page.

		 */

		page = virt_to_page(virtual_start);

		__free_reserved_page(page);



		virtual_start += PAGE_SIZE;

		mb_freed += PAGE_SIZE / 1024;

	}



	printk("acornfb: freed %dK memory\n", mb_freed);

}



static int acornfb_probe(struct platform_device *dev)

{

	unsigned long size;