Commit b38041d5 authored by Jack Wang's avatar Jack Wang Committed by Jason Gunthorpe
Browse files

RDMA/rtrs: Do not signal for heatbeat 

For HB, there is no need to generate signal for completion.

Also remove a comment accordingly.

Fixes: c0894b3e ("RDMA/rtrs: core: lib functions shared between client and server modules")
Link: https://lore.kernel.org/r/20201217141915.56989-16-jinpu.wang@cloud.ionos.com


Signed-off-by: default avatarJack Wang <jinpu.wang@cloud.ionos.com>
Reported-by: default avatarGioh Kim <gi-oh.kim@cloud.ionos.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent eab09824

drivers/infiniband/ulp/rtrs/rtrs-clt.c

+0 −1
Original line number Diff line number Diff line
@@ -664,7 +664,6 @@ static void rtrs_clt_rdma_done(struct ib_cq *cq, struct ib_wc *wc) 
	case IB_WC_RDMA_WRITE:

		/*

		 * post_send() RDMA write completions of IO reqs (read/write)

		 * and hb

		 */

		break;

drivers/infiniband/ulp/rtrs/rtrs-srv.c

+0 −1
Original line number Diff line number Diff line
@@ -1242,7 +1242,6 @@ static void rtrs_srv_rdma_done(struct ib_cq *cq, struct ib_wc *wc) 
	case IB_WC_SEND:

		/*

		 * post_send() RDMA write completions of IO reqs (read/write)

		 * and hb

		 */

		atomic_add(srv->queue_depth, &con->sq_wr_avail);

drivers/infiniband/ulp/rtrs/rtrs.c

+2 −2
Original line number Diff line number Diff line
@@ -310,7 +310,7 @@ void rtrs_send_hb_ack(struct rtrs_sess *sess) 


	imm = rtrs_to_imm(RTRS_HB_ACK_IMM, 0);

	err = rtrs_post_rdma_write_imm_empty(usr_con, sess->hb_cqe, imm,

					      IB_SEND_SIGNALED, NULL);

					     0, NULL);

	if (err) {

		sess->hb_err_handler(usr_con);

		return;
@@ -339,7 +339,7 @@ static void hb_work(struct work_struct *work) 
	}

	imm = rtrs_to_imm(RTRS_HB_MSG_IMM, 0);

	err = rtrs_post_rdma_write_imm_empty(usr_con, sess->hb_cqe, imm,

					      IB_SEND_SIGNALED, NULL);

					     0, NULL);

	if (err) {

		sess->hb_err_handler(usr_con);

		return;