Commit b370245b authored by Bruce Allan's avatar Bruce Allan Committed by Tony Nguyen
Browse files

ice: suppress false cppcheck issues 



Silence false errors, warnings and style issues reported by cppcheck.

Signed-off-by: default avatarBruce Allan <bruce.w.allan@intel.com>
Tested-by: default avatarTony Brelinski <tonyx.brelinski@intel.com>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent c931c782

drivers/net/ethernet/intel/ice/ice_flex_pipe.c

+3 −0
Original line number Diff line number Diff line
@@ -334,6 +334,7 @@ ice_boost_tcam_handler(u32 sect_type, void *section, u32 index, u32 *offset) 
	if (sect_type != ICE_SID_RXPARSER_BOOST_TCAM)

		return NULL;



	/* cppcheck-suppress nullPointer */

	if (index > ICE_MAX_BST_TCAMS_IN_BUF)

		return NULL;
@@ -404,6 +405,7 @@ ice_label_enum_handler(u32 __always_unused sect_type, void *section, u32 index, 
	if (!section)

		return NULL;



	/* cppcheck-suppress nullPointer */

	if (index > ICE_MAX_LABELS_IN_BUF)

		return NULL;
@@ -2067,6 +2069,7 @@ ice_match_prop_lst(struct list_head *list1, struct list_head *list2) 
		count++;

	list_for_each_entry(tmp2, list2, list)

		chk_count++;

	/* cppcheck-suppress knownConditionTrueFalse */

	if (!count || count != chk_count)

		return false;

drivers/net/ethernet/intel/ice/ice_nvm.c

+1 −0
Original line number Diff line number Diff line
@@ -644,6 +644,7 @@ ice_get_orom_civd_data(struct ice_hw *hw, enum ice_bank_select bank, 


		/* Verify that the simple checksum is zero */

		for (i = 0; i < sizeof(tmp); i++)

			/* cppcheck-suppress objectIndex */

			sum += ((u8 *)&tmp)[i];



		if (sum) {

drivers/net/ethernet/intel/ice/ice_sched.c

+1 −0
Original line number Diff line number Diff line
@@ -988,6 +988,7 @@ ice_sched_add_nodes_to_layer(struct ice_port_info *pi, 
	*num_nodes_added = 0;

	while (*num_nodes_added < num_nodes) {

		u16 max_child_nodes, num_added = 0;

		/* cppcheck-suppress unusedVariable */

		u32 temp;



		status = ice_sched_add_nodes_to_hw_layer(pi, tc_node, parent,