Unverified Commit b3401284 authored by Cristian Ciocaltea's avatar Cristian Ciocaltea Committed by Mark Brown
Browse files

ASoC: amd: vangogh: Use non-legacy DAI naming for cs35l41 



Unlike most CODEC drivers, the CS35L41 driver did not have the
non_legacy_dai_naming set, meaning the corresponding DAI has been
traditionally registered using the legacy naming: spi-VLV1776:0x

The recent migration to the new legacy DAI naming style has implicitly
corrected that behavior and DAI gets now registered via the non-legacy
naming, i.e. cs35l41-pcm.

The problem is the acp5x platform driver is now broken as it continues
to refer to the above mentioned codec using the legacy DAI naming in
function acp5x_cs35l41_hw_params() and, therefore, the related setup
is not being executed anymore.

Let's fix that by replacing the obsolete DAI name with the correct one.

Fixes: 129f055a ("ASoC: core: Switch core to new DAI naming flag")
Signed-off-by: default avatarCristian Ciocaltea <cristian.ciocaltea@collabora.com>
Reviewed-by: default avatarCharles Keepax <ckeepax@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20220722092700.8269-1-cristian.ciocaltea@collabora.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent a4b97655

sound/soc/amd/vangogh/acp5x-mach.c

+1 −2
Original line number Diff line number Diff line
@@ -178,8 +178,7 @@ static int acp5x_cs35l41_hw_params(struct snd_pcm_substream *substream, 
	ret = 0;

	for (i = 0; i < num_codecs; i++) {

		codec_dai = asoc_rtd_to_codec(rtd, i);

		if ((strcmp(codec_dai->name, "spi-VLV1776:00") == 0) ||

		    (strcmp(codec_dai->name, "spi-VLV1776:01") == 0)) {

		if (strcmp(codec_dai->name, "cs35l41-pcm") == 0) {

			switch (params_rate(params)) {

			case 48000:

				bclk_val = 1536000;