Commit b3260329 authored by Li Nan's avatar Li Nan Committed by Jens Axboe
Browse files

blk-iocost: change div64_u64 to DIV64_U64_ROUND_UP in ioc_refresh_params() 



vrate_min is calculated by DIV64_U64_ROUND_UP, but vrate_max is calculated
by div64_u64. Vrate_min may be 1 greater than vrate_max if the input
values min and max of cost.qos are equal.

Signed-off-by: default avatarLi Nan <linan122@huawei.com>
Signed-off-by: default avatarYu Kuai <yukuai3@huawei.com>
Acked-by: default avatarTejun Heo <tj@kernel.org>
Link: https://lore.kernel.org/r/20230117070806.3857142-6-yukuai1@huaweicloud.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 984af1e6

block/blk-iocost.c

+2 −2
Original line number Diff line number Diff line
@@ -933,7 +933,7 @@ static bool ioc_refresh_params(struct ioc *ioc, bool force) 


	ioc->vrate_min = DIV64_U64_ROUND_UP((u64)ioc->params.qos[QOS_MIN] *

					    VTIME_PER_USEC, MILLION);

	ioc->vrate_max = div64_u64((u64)ioc->params.qos[QOS_MAX] *

	ioc->vrate_max = DIV64_U64_ROUND_UP((u64)ioc->params.qos[QOS_MAX] *

					    VTIME_PER_USEC, MILLION);



	return true;