Commit b30a779d authored by Steven Rostedt (VMware)'s avatar Steven Rostedt (VMware)
Browse files

tracing: Initialize upper and lower vars in pid_list_refill_irq() 

The upper and lower variables are set as link lists to add into the sparse
array. If they are NULL, after the needed allocations are done, then there
is nothing to add. But they need to be initialized to NULL for this to
work.

Link: https://lore.kernel.org/all/221bc7ba-a475-1cb9-1bbe-730bb9c2d448@canonical.com/



Fixes: 8d6e9098 ("tracing: Create a sparse bitmask for pid filtering")
Reported-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarSteven Rostedt (VMware) <rostedt@goodmis.org>
parent 8d6e9098

kernel/trace/pid_list.c

+2 −2
Original line number Diff line number Diff line
@@ -333,8 +333,8 @@ static void pid_list_refill_irq(struct irq_work *iwork) 
{

	struct trace_pid_list *pid_list = container_of(iwork, struct trace_pid_list,

						       refill_irqwork);

	union upper_chunk *upper;

	union lower_chunk *lower;

	union upper_chunk *upper = NULL;

	union lower_chunk *lower = NULL;

	union upper_chunk **upper_next = &upper;

	union lower_chunk **lower_next = &lower;

	int upper_count;