Commit b2f6cb78 authored by Zhang Qilong's avatar Zhang Qilong Committed by Sebastian Reichel
Browse files

power: supply: bq24190_charger: fix reference leak 



pm_runtime_get_sync will increment pm usage counter even it
failed. Forgetting to call pm_runtime_put_noidle will result
in reference leak in callers(bq24190_sysfs_show,
bq24190_charger_get_property, bq24190_charger_set_property,
bq24190_battery_get_property, bq24190_battery_set_property),
so we should fix it.

Fixes: f385e6e2 ("power: bq24190_charger: Use PM runtime autosuspend")
Signed-off-by: default avatarZhang Qilong <zhangqilong3@huawei.com>
Signed-off-by: default avatarSebastian Reichel <sebastian.reichel@collabora.com>
parent 7776bcd2

drivers/power/supply/bq24190_charger.c

+15 −5
Original line number Diff line number Diff line
@@ -448,8 +448,10 @@ static ssize_t bq24190_sysfs_show(struct device *dev, 
		return -EINVAL;



	ret = pm_runtime_get_sync(bdi->dev);

	if (ret < 0)

	if (ret < 0) {

		pm_runtime_put_noidle(bdi->dev);

		return ret;

	}



	ret = bq24190_read_mask(bdi, info->reg, info->mask, info->shift, &v);

	if (ret)
@@ -1077,8 +1079,10 @@ static int bq24190_charger_get_property(struct power_supply *psy, 
	dev_dbg(bdi->dev, "prop: %d\n", psp);



	ret = pm_runtime_get_sync(bdi->dev);

	if (ret < 0)

	if (ret < 0) {

		pm_runtime_put_noidle(bdi->dev);

		return ret;

	}



	switch (psp) {

	case POWER_SUPPLY_PROP_CHARGE_TYPE:
@@ -1149,8 +1153,10 @@ static int bq24190_charger_set_property(struct power_supply *psy, 
	dev_dbg(bdi->dev, "prop: %d\n", psp);



	ret = pm_runtime_get_sync(bdi->dev);

	if (ret < 0)

	if (ret < 0) {

		pm_runtime_put_noidle(bdi->dev);

		return ret;

	}



	switch (psp) {

	case POWER_SUPPLY_PROP_ONLINE:
@@ -1410,8 +1416,10 @@ static int bq24190_battery_get_property(struct power_supply *psy, 
	dev_dbg(bdi->dev, "prop: %d\n", psp);



	ret = pm_runtime_get_sync(bdi->dev);

	if (ret < 0)

	if (ret < 0) {

		pm_runtime_put_noidle(bdi->dev);

		return ret;

	}



	switch (psp) {

	case POWER_SUPPLY_PROP_STATUS:
@@ -1456,8 +1464,10 @@ static int bq24190_battery_set_property(struct power_supply *psy, 
	dev_dbg(bdi->dev, "prop: %d\n", psp);



	ret = pm_runtime_get_sync(bdi->dev);

	if (ret < 0)

	if (ret < 0) {

		pm_runtime_put_noidle(bdi->dev);

		return ret;

	}



	switch (psp) {

	case POWER_SUPPLY_PROP_ONLINE: