Commit b2ec76c5 authored by Bart Van Assche's avatar Bart Van Assche Committed by James Bottomley
Browse files

[SCSI] qla2xxx: Fix qla2xxx_check_risc_status(). 



Change the 'rval' variable from QLA_FUNCTION_TIMEOUT into QLA_SUCCESS
before starting a loop that is only executed if rval is initialized
to QLA_SUCCESS. Coverity reported that loop as "dead code".

Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarSaurav Kashyap <saurav.kashyap@qlogic.com>
Signed-off-by: default avatarJames Bottomley <JBottomley@Parallels.com>
parent 6ec6f909

drivers/scsi/qla2xxx/qla_isr.c

+1 −0
Original line number Diff line number Diff line
@@ -2485,6 +2485,7 @@ qla2xxx_check_risc_status(scsi_qla_host_t *vha) 
	if (rval == QLA_SUCCESS)

		goto next_test;



	rval = QLA_SUCCESS;

	WRT_REG_DWORD(&reg->iobase_window, 0x0003);

	for (cnt = 100; (RD_REG_DWORD(&reg->iobase_window) & BIT_0) == 0 &&

	    rval == QLA_SUCCESS; cnt--) {