Commit b2b76e97 authored by Cristian Marussi's avatar Cristian Marussi Committed by Sudeep Holla
Browse files

firmware: arm_scmi: Fix raw coexistence mode behaviour on failure path 



When SCMI raw coexistence mode is enabled make the core stack probe
successfully even when the initial base protocol exchanges with the
platform/server failed.

This behaviour enables the system to boot with a broken regular SCMI
stack but with a fully functional and accessible SCMI raw debugfs
interface that can be used to further debug the issue.

Signed-off-by: default avatarCristian Marussi <cristian.marussi@arm.com>
Link: https://lore.kernel.org/r/20230223152330.2707260-1-cristian.marussi@arm.com


Signed-off-by: default avatarSudeep Holla <sudeep.holla@arm.com>
parent 418a406d

drivers/firmware/arm_scmi/driver.c

+3 −3
Original line number Diff line number Diff line
@@ -2657,6 +2657,7 @@ static int scmi_probe(struct platform_device *pdev) 
	struct scmi_handle *handle;

	const struct scmi_desc *desc;

	struct scmi_info *info;

	bool coex = IS_ENABLED(CONFIG_ARM_SCMI_RAW_MODE_SUPPORT_COEX);

	struct device *dev = &pdev->dev;

	struct device_node *child, *np = dev->of_node;
@@ -2731,9 +2732,6 @@ static int scmi_probe(struct platform_device *pdev) 
			dev_warn(dev, "Failed to setup SCMI debugfs.\n");



		if (IS_ENABLED(CONFIG_ARM_SCMI_RAW_MODE_SUPPORT)) {

			bool coex =

			      IS_ENABLED(CONFIG_ARM_SCMI_RAW_MODE_SUPPORT_COEX);



			ret = scmi_debugfs_raw_mode_setup(info);

			if (!coex) {

				if (ret)
@@ -2764,6 +2762,8 @@ static int scmi_probe(struct platform_device *pdev) 
	ret = scmi_protocol_acquire(handle, SCMI_PROTOCOL_BASE);

	if (ret) {

		dev_err(dev, "unable to communicate with SCMI\n");

		if (coex)

			return 0;

		goto notification_exit;

	}