Commit b28dbcb3 authored by Jianglei Nie's avatar Jianglei Nie Committed by Sebastian Reichel
Browse files

HSI: ssi_protocol: fix potential resource leak in ssip_pn_open() 



ssip_pn_open() claims the HSI client's port with hsi_claim_port(). When
hsi_register_port_event() gets some error and returns a negetive value,
the HSI client's port should be released with hsi_release_port().

Fix it by calling hsi_release_port() when hsi_register_port_event() fails.

Signed-off-by: default avatarJianglei Nie <niejianglei2021@163.com>
Signed-off-by: default avatarSebastian Reichel <sebastian.reichel@collabora.com>
parent 551e325b

drivers/hsi/clients/ssi_protocol.c

+1 −0
Original line number Diff line number Diff line
@@ -930,6 +930,7 @@ static int ssip_pn_open(struct net_device *dev) 
	if (err < 0) {

		dev_err(&cl->device, "Register HSI port event failed (%d)\n",

			err);

		hsi_release_port(cl);

		return err;

	}

	dev_dbg(&cl->device, "Configuring SSI port\n");