Commit b24ede22 authored by Junaid Shahid's avatar Junaid Shahid Committed by Sean Christopherson
Browse files

kvm: x86: Do proper cleanup if kvm_x86_ops->vm_init() fails 



If vm_init() fails [which can happen, for instance, if a memory
allocation fails during avic_vm_init()], we need to cleanup some
state in order to avoid resource leaks.

Signed-off-by: default avatarJunaid Shahid <junaids@google.com>
Link: https://lore.kernel.org/r/20220729224329.323378-1-junaids@google.com


Signed-off-by: default avatarSean Christopherson <seanjc@google.com>
parent 372d0708

arch/x86/kvm/x86.c

+7 −1
Original line number Diff line number Diff line
@@ -12054,6 +12054,10 @@ int kvm_arch_init_vm(struct kvm *kvm, unsigned long type) 
	if (ret)

		goto out_page_track;



	ret = static_call(kvm_x86_vm_init)(kvm);

	if (ret)

		goto out_uninit_mmu;



	INIT_HLIST_HEAD(&kvm->arch.mask_notifier_list);

	INIT_LIST_HEAD(&kvm->arch.assigned_dev_head);

	atomic_set(&kvm->arch.noncoherent_dma_count, 0);
@@ -12089,8 +12093,10 @@ int kvm_arch_init_vm(struct kvm *kvm, unsigned long type) 
	kvm_hv_init_vm(kvm);

	kvm_xen_init_vm(kvm);



	return static_call(kvm_x86_vm_init)(kvm);

	return 0;



out_uninit_mmu:

	kvm_mmu_uninit_vm(kvm);

out_page_track:

	kvm_page_track_cleanup(kvm);

out: