Commit b23fcf47 authored by Pavel Begunkov's avatar Pavel Begunkov Committed by Jens Axboe
Browse files

io_uring: remove extra in_idle wake up 



io_dismantle_req() is always followed by io_put_task(), which already do
proper in_idle wake ups, so we can skip waking the owner task in
io_dismantle_req(). The rules are simpler now, do io_put_task() shortly
after ending a request, and it will be fine.

Signed-off-by: default avatarPavel Begunkov <asml.silence@gmail.com>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent ebf93667

fs/io_uring.c

+1 −3
Original line number Diff line number Diff line
@@ -1649,18 +1649,16 @@ static void io_dismantle_req(struct io_kiocb *req) 


	if (req->flags & REQ_F_INFLIGHT) {

		struct io_ring_ctx *ctx = req->ctx;

		struct io_uring_task *tctx = req->task->io_uring;

		unsigned long flags;



		spin_lock_irqsave(&ctx->inflight_lock, flags);

		list_del(&req->inflight_entry);

		spin_unlock_irqrestore(&ctx->inflight_lock, flags);

		req->flags &= ~REQ_F_INFLIGHT;

		if (atomic_read(&tctx->in_idle))

			wake_up(&tctx->wait);

	}

}



/* must to be called somewhat shortly after putting a request */

static inline void io_put_task(struct task_struct *task, int nr)

{

	struct io_uring_task *tctx = task->io_uring;