Commit b20fd5fa authored by Amelie Delaunay's avatar Amelie Delaunay Committed by Vinod Koul
Browse files

dmaengine: stm32-dma: fix stm32_dma_get_max_width 



buf_addr parameter of stm32_dma_set_xfer_param function is a dma_addr_t.
We only need to check the remainder of buf_addr/max_width, so, no need to
use do_div and extra u64 addr. Use '%' instead.

Fixes: e0ebdbdc ("dmaengine: stm32-dma: take address into account when computing max width")
Signed-off-by: default avatarAmelie Delaunay <amelie.delaunay@foss.st.com>
Link: https://lore.kernel.org/r/20211011094259.315023-3-amelie.delaunay@foss.st.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 79e40b06

drivers/dma/stm32-dma.c

+1 −2
Original line number Diff line number Diff line
@@ -270,7 +270,6 @@ static enum dma_slave_buswidth stm32_dma_get_max_width(u32 buf_len, 
						       u32 threshold)

{

	enum dma_slave_buswidth max_width;

	u64 addr = buf_addr;



	if (threshold == STM32_DMA_FIFO_THRESHOLD_FULL)

		max_width = DMA_SLAVE_BUSWIDTH_4_BYTES;
@@ -281,7 +280,7 @@ static enum dma_slave_buswidth stm32_dma_get_max_width(u32 buf_len, 
	       max_width > DMA_SLAVE_BUSWIDTH_1_BYTE)

		max_width = max_width >> 1;



	if (do_div(addr, max_width))

	if (buf_addr % max_width)

		max_width = DMA_SLAVE_BUSWIDTH_1_BYTE;



	return max_width;