Commit b2058cd9 authored by Dmitry Torokhov's avatar Dmitry Torokhov
Browse files

Input: gtco - remove driver 

The driver has its own HID descriptor parsing code, that had and still
has several issues discovered by syzbot and other tools. Ideally we
should move the driver over to the HID subsystem, so that it uses proven
parsing code.  However the devices in question are EOL, and GTCO is not
willing to extend resources for that, so let's simply remove the driver.

Note that our HID support has greatly improved over the last 10 years,
we may also consider reverting 6f8d9e26 ("hid-core.c: Adds all GTCO
CalComp Digitizers and InterWrite School Products to blacklist") and see
if GTCO devices actually work with normal HID drivers.

Link: https://lore.kernel.org/r/X8wbBtO5KidME17K@google.com


Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent 7ce8d91b

arch/powerpc/configs/ppc6xx_defconfig

+0 −1
Original line number Diff line number Diff line
@@ -579,7 +579,6 @@ CONFIG_JOYSTICK_XPAD_LEDS=y 
CONFIG_INPUT_TABLET=y

CONFIG_TABLET_USB_ACECAD=m

CONFIG_TABLET_USB_AIPTEK=m

CONFIG_TABLET_USB_GTCO=m

CONFIG_TABLET_USB_KBTAB=m

CONFIG_INPUT_MISC=y

CONFIG_INPUT_PCSPKR=m

drivers/input/tablet/Kconfig

+0 −12
Original line number Diff line number Diff line
@@ -38,18 +38,6 @@ config TABLET_USB_AIPTEK 
	  To compile this driver as a module, choose M here: the

	  module will be called aiptek.



config TABLET_USB_GTCO

	tristate "GTCO CalComp/InterWrite USB Support"

	depends on USB && INPUT

	help

	  Say Y here if you want to use the USB version of the GTCO

	  CalComp/InterWrite Tablet.  Make sure to say Y to "Mouse support"

	  (CONFIG_INPUT_MOUSEDEV) and/or "Event interface support"

	  (CONFIG_INPUT_EVDEV) as well.



	  To compile this driver as a module, choose M here: the

	  module will be called gtco.



config TABLET_USB_HANWANG

	tristate "Hanwang Art Master III tablet support (USB)"

	depends on USB_ARCH_HAS_HCD

drivers/input/tablet/Makefile

+0 −1
Original line number Diff line number Diff line
@@ -6,7 +6,6 @@ 


obj-$(CONFIG_TABLET_USB_ACECAD)	+= acecad.o

obj-$(CONFIG_TABLET_USB_AIPTEK)	+= aiptek.o

obj-$(CONFIG_TABLET_USB_GTCO)	+= gtco.o

obj-$(CONFIG_TABLET_USB_HANWANG) += hanwang.o

obj-$(CONFIG_TABLET_USB_KBTAB)	+= kbtab.o

obj-$(CONFIG_TABLET_USB_PEGASUS) += pegasus_notetaker.o

drivers/input/tablet/gtco.c

deleted100644 → 0
+0 −1043

File deleted.

Preview size limit exceeded, changes collapsed.

kernel/configs/android-recommended.config

+0 −1
Original line number Diff line number Diff line
@@ -111,7 +111,6 @@ CONFIG_STRICT_KERNEL_RWX=y 
CONFIG_SUSPEND_TIME=y

CONFIG_TABLET_USB_ACECAD=y

CONFIG_TABLET_USB_AIPTEK=y

CONFIG_TABLET_USB_GTCO=y

CONFIG_TABLET_USB_HANWANG=y

CONFIG_TABLET_USB_KBTAB=y

CONFIG_TASKSTATS=y