Commit b1e42861 authored Aug 15, 2023 by Viktor Mihajlovski Committed by Janosch Frank Aug 28, 2023

KVM: s390: pv: relax WARN_ONCE condition for destroy fast



Destroy configuration fast may return with RC 0x104 if there
are still bound APQNs in the configuration. The final cleanup
will occur with the standard destroy configuration UVC as
at this point in time all APQNs have been reset and thus
unbound. Therefore, don't warn if RC 0x104 is reported.

Signed-off-by: Viktor Mihajlovski <mihajlov@linux.ibm.com>
Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
Reviewed-by: Janosch Frank <frankja@linux.ibm.com>
Reviewed-by: Steffen Eiden <seiden@linux.ibm.com>
Reviewed-by: Michael Mueller <mimu@linux.ibm.com>
Link: https://lore.kernel.org/r/20230815151415.379760-2-seiden@linux.ibm.com


Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
Message-ID: <20230815151415.379760-2-seiden@linux.ibm.com>

parent 5d0545ab

arch/s390/kvm/pv.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -285,7 +285,8 @@ static int kvm_s390_pv_deinit_vm_fast(struct kvm kvm, u16 rc, u16 *rrc)
		WRITE_ONCE(kvm->arch.gmap->guest_handle, 0);
		KVM_UV_EVENT(kvm, 3, "PROTVIRT DESTROY VM FAST: rc %x rrc %x",
		uvcb.header.rc, uvcb.header.rrc);
		WARN_ONCE(cc, "protvirt destroy vm fast failed handle %llx rc %x rrc %x",
		WARN_ONCE(cc && uvcb.header.rc != 0x104,
		"protvirt destroy vm fast failed handle %llx rc %x rrc %x",
		kvm_s390_pv_get_handle(kvm), uvcb.header.rc, uvcb.header.rrc);
		/* Intended memory leak on "impossible" error */
		if (!cc)