Commit b1e3a560 authored by Steffen Klassert's avatar Steffen Klassert
Browse files

xfrm: Fix NULL pointer dereference on policy lookup 



When xfrm interfaces are used in combination with namespaces
and ESP offload, we get a dst_entry NULL pointer dereference.
This is because we don't have a dst_entry attached in the ESP
offloading case and we need to do a policy lookup before the
namespace transition.

Fix this by expicit checking of skb_dst(skb) before accessing it.

Fixes: f203b76d ("xfrm: Add virtual xfrm interfaces")
Signed-off-by: default avatarSteffen Klassert <steffen.klassert@secunet.com>
parent 68dc022d

include/net/xfrm.h

+1 −1
Original line number Diff line number Diff line
@@ -1097,7 +1097,7 @@ static inline int __xfrm_policy_check2(struct sock *sk, int dir, 
		return __xfrm_policy_check(sk, ndir, skb, family);



	return	(!net->xfrm.policy_count[dir] && !secpath_exists(skb)) ||

		(skb_dst(skb)->flags & DST_NOPOLICY) ||

		(skb_dst(skb) && (skb_dst(skb)->flags & DST_NOPOLICY)) ||

		__xfrm_policy_check(sk, ndir, skb, family);

}