Commit b1d65f71 authored by Wei Yongjun's avatar Wei Yongjun Committed by Michael S. Tsirkin
Browse files

virtio-crypto: fix memory leak in virtio_crypto_alg_skcipher_close_session() 



'vc_ctrl_req' is alloced in virtio_crypto_alg_skcipher_close_session(),
and should be freed in the invalid ctrl_status->status error handling
case. Otherwise there is a memory leak.

Fixes: 0756ad15 ("virtio-crypto: use private buffer for control request")
Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Message-Id: <20221114110740.537276-1-weiyongjun@huaweicloud.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Reviewed-by: default avatarGonglei <arei.gonglei@huawei.com>
Acked-by: default avatarzhenwei <pi&lt;pizhenwei@bytedance.com>
Acked-by: default avatarJason Wang <jasowang@redhat.com>
parent a4722f64

drivers/crypto/virtio/virtio_crypto_skcipher_algs.c

+2 −1
Original line number Diff line number Diff line
@@ -239,7 +239,8 @@ static int virtio_crypto_alg_skcipher_close_session( 
		pr_err("virtio_crypto: Close session failed status: %u, session_id: 0x%llx\n",

			ctrl_status->status, destroy_session->session_id);



		return -EINVAL;

		err = -EINVAL;

		goto out;

	}



	err = 0;