Commit b1d0d2eb authored by Kiwoong Kim's avatar Kiwoong Kim Committed by Martin K. Petersen
Browse files

scsi: ufs: Add a quirk to permit overriding UniPro defaults 

The UniPro specification states that attribute IDs of the following
parameters are vendor-specific so some SoCs could have no regions at the
defined addresses:

 - DME_LocalFC0ProtectionTimeOutVal
 - DME_LocalTC0ReplayTimeOutVal
 - DME_LocalAFC0ReqTimeOutVal

In addition, the following parameters should be set considering the
compatibility between host and device.

 - PA_PWRMODEUSERDATA0
 - PA_PWRMODEUSERDATA1
 - PA_PWRMODEUSERDATA2
 - PA_PWRMODEUSERDATA3
 - PA_PWRMODEUSERDATA4
 - PA_PWRMODEUSERDATA5

Introduce a quirk to allow vendor drivers to override the UniPro defaults.

Link: https://lore.kernel.org/r/1fedd3dea0ccc980913a5995a10510d86a5b01b9.1608513782.git.kwmad.kim@samsung.com


Acked-by: default avatarAvri Altman <Avri.Altman@wdc.com>
Signed-off-by: default avatarKiwoong Kim <kwmad.kim@samsung.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 46ec9592

drivers/scsi/ufs/ufshcd.c

+21 −19
Original line number Diff line number Diff line
@@ -4215,6 +4215,7 @@ static int ufshcd_change_power_mode(struct ufs_hba *hba, 
		ufshcd_dme_set(hba, UIC_ARG_MIB(PA_HSSERIES),

						pwr_mode->hs_rate);



	if (!(hba->quirks & UFSHCD_QUIRK_SKIP_DEF_UNIPRO_TIMEOUT_SETTING)) {

		ufshcd_dme_set(hba, UIC_ARG_MIB(PA_PWRMODEUSERDATA0),

				DL_FC0ProtectionTimeOutVal_Default);

		ufshcd_dme_set(hba, UIC_ARG_MIB(PA_PWRMODEUSERDATA1),
@@ -4234,6 +4235,7 @@ static int ufshcd_change_power_mode(struct ufs_hba *hba, 
				DL_TC0ReplayTimeOutVal_Default);

		ufshcd_dme_set(hba, UIC_ARG_MIB(DME_LocalAFC0ReqTimeOutVal),

				DL_AFC0ReqTimeOutVal_Default);

	}



	ret = ufshcd_uic_change_pwr_mode(hba, pwr_mode->pwr_rx << 4

			| pwr_mode->pwr_tx);

drivers/scsi/ufs/ufshcd.h

+6 −0
Original line number Diff line number Diff line
@@ -551,6 +551,12 @@ enum ufshcd_quirks { 
	 */

	UFSHCI_QUIRK_SKIP_MANUAL_WB_FLUSH_CTRL		= 1 << 12,



	/*

	 * This quirk needs to disable unipro timeout values

	 * before power mode change

	 */

	UFSHCD_QUIRK_SKIP_DEF_UNIPRO_TIMEOUT_SETTING = 1 << 13,



};



enum ufshcd_caps {