Commit b1bd5714 authored by Pali Rohár's avatar Pali Rohár Committed by Lorenzo Pieralisi
Browse files

PCI: aardvark: Indicate error in 'val' when config read fails 

Most callers of config read do not check for return value. But most of the
ones that do, checks for error indication in 'val' variable.

This patch updates error handling in advk_pcie_rd_conf() function. If PIO
transfer fails then 'val' variable is set to 0xffffffff which indicates
failture.

Link: https://lore.kernel.org/r/20200528162604.GA323482@bjorn-Precision-5520
Link: https://lore.kernel.org/r/20200601130315.18895-1-pali@kernel.org


Reported-by: default avatarBjorn Helgaas <helgaas@kernel.org>
Signed-off-by: default avatarPali Rohár <pali@kernel.org>
Signed-off-by: default avatarLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
parent b3a9e3b9

drivers/pci/controller/pci-aardvark.c

+3 −1
Original line number Diff line number Diff line
@@ -688,8 +688,10 @@ static int advk_pcie_rd_conf(struct pci_bus *bus, u32 devfn, 
	advk_writel(pcie, 1, PIO_START);



	ret = advk_pcie_wait_pio(pcie);

	if (ret < 0)

	if (ret < 0) {

		*val = 0xffffffff;

		return PCIBIOS_SET_FAILED;

	}



	advk_pcie_check_pio_status(pcie);