Commit b17b2d57 authored by Petr Machata's avatar Petr Machata Committed by Jakub Kicinski
Browse files

mlxsw: spectrum_router: hw_stats: Use tracker helpers to hold & put netdevices 



Using the tracking helpers makes it easier to debug netdevice refcount
imbalances when CONFIG_NET_DEV_REFCNT_TRACKER is enabled.

Convert dev_hold() / dev_put() to netdev_hold() / netdev_put() in the
router code that deals with hw_stats events.

Signed-off-by: default avatarPetr Machata <petrm@nvidia.com>
Reviewed-by: default avatarIdo Schimmel <idosch@nvidia.com>
Reviewed-by: default avatarEric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/b972314cfef4f4c24e66e60d13cffa5d606d1bf3.1690471774.git.petrm@nvidia.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent deeaa371

drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c

+3 −2
Original line number Diff line number Diff line
@@ -8308,6 +8308,7 @@ mlxsw_sp_router_port_l3_stats_report_delta(struct mlxsw_sp_rif *rif, 
struct mlxsw_sp_router_hwstats_notify_work {

	struct work_struct work;

	struct net_device *dev;

	netdevice_tracker dev_tracker;

};



static void mlxsw_sp_router_hwstats_notify_work(struct work_struct *work)
@@ -8319,7 +8320,7 @@ static void mlxsw_sp_router_hwstats_notify_work(struct work_struct *work) 
	rtnl_lock();

	rtnl_offload_xstats_notify(hws_work->dev);

	rtnl_unlock();

	dev_put(hws_work->dev);

	netdev_put(hws_work->dev, &hws_work->dev_tracker);

	kfree(hws_work);

}
@@ -8339,7 +8340,7 @@ mlxsw_sp_router_hwstats_notify_schedule(struct net_device *dev) 
		return;



	INIT_WORK(&hws_work->work, mlxsw_sp_router_hwstats_notify_work);

	dev_hold(dev);

	netdev_hold(dev, &hws_work->dev_tracker, GFP_KERNEL);

	hws_work->dev = dev;

	mlxsw_core_schedule_work(&hws_work->work);

}