Commit b17233d3 authored by Stephane Grosjean's avatar Stephane Grosjean Committed by Marc Kleine-Budde
Browse files

can: peak_pciefd: pucan_handle_status(): fix a potential starvation issue in TX path 

Rather than just indicating that transmission can start, this patch
requires the explicit flushing of the network TX queue when the driver
is informed by the device that it can transmit, next to its
configuration.

In this way, if frames have already been written by the application,
they will actually be transmitted.

Fixes: ffd137f7 ("can: peak/pcie_fd: remove useless code when interface starts")
Link: https://lore.kernel.org/r/20210623142600.149904-1-s.grosjean@peak-system.com


Cc: linux-stable <stable@vger.kernel.org>
Signed-off-by: default avatarStephane Grosjean <s.grosjean@peak-system.com>
Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent aaf473d0

drivers/net/can/peak_canfd/peak_canfd.c

+2 −2
Original line number Diff line number Diff line
@@ -351,8 +351,8 @@ static int pucan_handle_status(struct peak_canfd_priv *priv, 
				return err;

		}



		/* start network queue (echo_skb array is empty) */

		netif_start_queue(ndev);

		/* wake network queue up (echo_skb array is empty) */

		netif_wake_queue(ndev);



		return 0;

	}