Commit b15ed546 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Jens Axboe
Browse files

loop: initialize the worker tracking fields once 



There is no need to reinitialize idle_worker_list, worker_tree and timer
every time a loop device is configured.  Just initialize them once at
allocation time.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
Reviewed-by: default avatarChaitanya Kulkarni <kch@nvidia.com>
Tested-by: default avatarDarrick J. Wong <djwong@kernel.org>
Link: https://lore.kernel.org/r/20220330052917.2566582-8-hch@lst.de


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 2cf429b5

drivers/block/loop.c

+3 −4
Original line number Diff line number Diff line
@@ -1052,10 +1052,6 @@ static int loop_configure(struct loop_device *lo, fmode_t mode, 


	INIT_WORK(&lo->rootcg_work, loop_rootcg_workfn);

	INIT_LIST_HEAD(&lo->rootcg_cmd_list);

	INIT_LIST_HEAD(&lo->idle_worker_list);

	lo->worker_tree = RB_ROOT;

	timer_setup(&lo->timer, loop_free_idle_workers_timer,

		TIMER_DEFERRABLE);

	lo->use_dio = lo->lo_flags & LO_FLAGS_DIRECT_IO;

	lo->lo_device = bdev;

	lo->lo_backing_file = file;
@@ -1969,6 +1965,9 @@ static int loop_add(int i) 
	lo = kzalloc(sizeof(*lo), GFP_KERNEL);

	if (!lo)

		goto out;

	lo->worker_tree = RB_ROOT;

	INIT_LIST_HEAD(&lo->idle_worker_list);

	timer_setup(&lo->timer, loop_free_idle_workers_timer, TIMER_DEFERRABLE);

	lo->lo_state = Lo_unbound;



	err = mutex_lock_killable(&loop_ctl_mutex);