Commit b1307621 authored by Guillaume Nault's avatar Guillaume Nault Committed by Jakub Kicinski
Browse files

net/sched: act_gate: Unlock ->tcfa_lock in tc_setup_flow_action() 



We need to jump to the "err_out_locked" label when
tcf_gate_get_entries() fails. Otherwise, tc_setup_flow_action() exits
with ->tcfa_lock still held.

Fixes: d29bdd69 ("net: schedule: add action gate offloading")
Signed-off-by: default avatarGuillaume Nault <gnault@redhat.com>
Acked-by: default avatarCong Wang <xiyou.wangcong@gmail.com>
Link: https://lore.kernel.org/r/12f60e385584c52c22863701c0185e40ab08a7a7.1603207948.git.gnault@redhat.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent d978d6d0

net/sched/cls_api.c

+1 −1
Original line number Diff line number Diff line
@@ -3712,7 +3712,7 @@ int tc_setup_flow_action(struct flow_action *flow_action, 
			entry->gate.num_entries = tcf_gate_num_entries(act);

			err = tcf_gate_get_entries(entry, act);

			if (err)

				goto err_out;

				goto err_out_locked;

		} else {

			err = -EOPNOTSUPP;

			goto err_out_locked;