Commit b12d5944 authored by Ville Syrjälä's avatar Ville Syrjälä
Browse files

drm/i915: Don't pass stack garbage to pcode in the second data register 



Zero initialize val2 so that we don't pass stack garbage to
the pcode qgv read command. I suspect in this case pcode
just ignores the initial value in that registers, but better
safe than sorry.

Cc: Dan Carpenter <dan.carpenter@oracle.com>
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190710134937.25835-1-ville.syrjala@linux.intel.com


Reviewed-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
parent a85fb467

drivers/gpu/drm/i915/display/intel_bw.c

+1 −1
Original line number Diff line number Diff line
@@ -65,7 +65,7 @@ static int icl_pcode_read_qgv_point_info(struct drm_i915_private *dev_priv, 
					 struct intel_qgv_point *sp,

					 int point)

{

	u32 val = 0, val2;

	u32 val = 0, val2 = 0;

	int ret;



	ret = sandybridge_pcode_read(dev_priv,