Commit b0e84815 authored by Colin Ian King's avatar Colin Ian King Committed by Mauro Carvalho Chehab
Browse files

media: staging: atomisp: remove redundant assignments to various variables 



There are various assignments that are being made to variables that are
not read and the variables are being updated later on, hence the redundant
assignments can be removed.

Cleans up clang warnings:
drivers/staging/media/atomisp/i2c/ov5693/atomisp-ov5693.c:1950:8:
warning: Value stored to 'pdata' during its initialization is never read
drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c:1853:29:
warning: Value stored to 'asd' during its initialization is never read
drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_css20.c:4505:29:
warning: Value stored to 'asd' during its initialization is never read
drivers/staging/media/atomisp/pci/atomisp2/atomisp_v4l2.c:1139:30:
warning: Value stored to 'asd' during its initialization is never read
drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css.c:6961:27:
warning: Value stored to 'tmp_in_info' during its initialization is
never read

Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent a9b539a6

drivers/staging/media/atomisp/i2c/ov5693/atomisp-ov5693.c

+1 −1
Original line number Diff line number Diff line
@@ -1893,7 +1893,7 @@ static int ov5693_probe(struct i2c_client *client) 
	struct ov5693_device *dev;

	int i2c;

	int ret = 0;

	void *pdata = client->dev.platform_data;

	void *pdata;

	unsigned int i;



	/*

drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c

+1 −1
Original line number Diff line number Diff line
@@ -1850,7 +1850,7 @@ irqreturn_t atomisp_isr_thread(int irq, void *isp_ptr) 
	bool frame_done_found[MAX_STREAM_NUM] = {0};

	bool css_pipe_done[MAX_STREAM_NUM] = {0};

	unsigned int i;

	struct atomisp_sub_device *asd = &isp->asd[0];

	struct atomisp_sub_device *asd;



	dev_dbg(isp->dev, ">%s\n", __func__);

drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_css20.c

+1 −1
Original line number Diff line number Diff line
@@ -4502,7 +4502,7 @@ int atomisp_css_isr_thread(struct atomisp_device *isp, 
{

	enum atomisp_input_stream_id stream_id = 0;

	struct atomisp_css_event current_event;

	struct atomisp_sub_device *asd = &isp->asd[0];

	struct atomisp_sub_device *asd;

#ifndef ISP2401

	bool reset_wdt_timer[MAX_STREAM_NUM] = {false};

#endif

drivers/staging/media/atomisp/pci/atomisp2/atomisp_v4l2.c

+0 −1
Original line number Diff line number Diff line
@@ -1137,7 +1137,6 @@ static int init_atomisp_wdts(struct atomisp_device *isp) 


	for (i = 0; i < isp->num_of_streams; i++) {

		struct atomisp_sub_device *asd = &isp->asd[i];

		asd = &isp->asd[i];

#ifndef ISP2401

		timer_setup(&asd->wdt, atomisp_wdt, 0);

#else

drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css.c

+1 −1
Original line number Diff line number Diff line
@@ -6958,7 +6958,7 @@ static enum ia_css_err ia_css_pipe_create_cas_scaler_desc_single_output( 
	unsigned int i;

	unsigned int hor_ds_factor = 0, ver_ds_factor = 0;

	enum ia_css_err err = IA_CSS_SUCCESS;

	struct ia_css_frame_info tmp_in_info = IA_CSS_BINARY_DEFAULT_FRAME_INFO;

	struct ia_css_frame_info tmp_in_info;



	unsigned max_scale_factor_per_stage = MAX_PREFERRED_YUV_DS_PER_STEP;