Commit b0d713c6 authored by Maximilian Luz's avatar Maximilian Luz Committed by Jiri Kosina
Browse files

HID: surface-hid: Fix integer endian conversion 



We want to convert from 16 bit (unsigned) little endian values contained
in a packed struct to CPU native endian values here, not the other way
around. So replace cpu_to_le16() with get_unaligned_le16(), using the
latter instead of le16_to_cpu() to acknowledge that we are reading from
a packed struct.

Reported-by: default avatarkernel test robot <lkp@intel.com>
Fixes: b05ff100 ("HID: Add support for Surface Aggregator Module HID transport")
Signed-off-by: default avatarMaximilian Luz <luzmaximilian@gmail.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent 0f0fb3d2

drivers/hid/surface-hid/surface_hid_core.c

+3 −3
Original line number Diff line number Diff line
@@ -168,9 +168,9 @@ int surface_hid_device_add(struct surface_hid_device *shid) 


	shid->hid->dev.parent = shid->dev;

	shid->hid->bus = BUS_HOST;

	shid->hid->vendor = cpu_to_le16(shid->attrs.vendor);

	shid->hid->product = cpu_to_le16(shid->attrs.product);

	shid->hid->version = cpu_to_le16(shid->hid_desc.hid_version);

	shid->hid->vendor = get_unaligned_le16(&shid->attrs.vendor);

	shid->hid->product = get_unaligned_le16(&shid->attrs.product);

	shid->hid->version = get_unaligned_le16(&shid->hid_desc.hid_version);

	shid->hid->country = shid->hid_desc.country_code;



	snprintf(shid->hid->name, sizeof(shid->hid->name), "Microsoft Surface %04X:%04X",