Commit b0bf77cd authored by Colin Ian King's avatar Colin Ian King Committed by Greg Kroah-Hartman
Browse files

usb: dwc3: Fix dereferencing of null dwc->usb_psy 



Currently the null check logic on dwc->usb_psy is inverted as it allows
calls to power_supply_put with a null dwc->usb_psy causing a null
pointer dereference. Fix this by removing the ! operator.

Addresses-Coverity: ("Dereference after null check")
Fixes: 59fa3def35de ("usb: dwc3: add a power supply for current control")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20210303095826.6143-1-colin.king@canonical.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 92d1e87e

drivers/usb/dwc3/core.c

+2 −2
Original line number Diff line number Diff line
@@ -1628,7 +1628,7 @@ static int dwc3_probe(struct platform_device *pdev) 
assert_reset:

	reset_control_assert(dwc->reset);



	if (!dwc->usb_psy)

	if (dwc->usb_psy)

		power_supply_put(dwc->usb_psy);



	return ret;
@@ -1653,7 +1653,7 @@ static int dwc3_remove(struct platform_device *pdev) 
	dwc3_free_event_buffers(dwc);

	dwc3_free_scratch_buffers(dwc);



	if (!dwc->usb_psy)

	if (dwc->usb_psy)

		power_supply_put(dwc->usb_psy);



	return 0;