Commit b0a347be authored by Martin Kaiser's avatar Martin Kaiser Committed by Greg Kroah-Hartman
Browse files

staging: r8188eu: remove the bInSuspend loop 



Remove the loop in rtw_pwr_wakeup that waits while the system is
suspended.

pwrpriv->bInSuspend is set in rtw_suspend and cleared in rtw_resume. These
functions are the .suspend and .resume functions of the struct usb_driver
for r8188eu.

A usb_driver's suspend and resume functions are called when the entire
system goes into suspend or runtime suspend.

All of the code paths for rtw_pwr_wakeup start at ioctl handlers.

We can remove the loop that checks bInSuspend. It's not possible to call
an ioctl while the entire system is suspended.

Signed-off-by: default avatarMartin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20220413193654.258507-8-martin@kaiser.cx


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 1dd0ac70

drivers/staging/r8188eu/core/rtw_pwrctrl.c

+0 −4
Original line number Diff line number Diff line
@@ -379,10 +379,6 @@ int rtw_pwr_wakeup(struct adapter *padapter) 
	while (pwrpriv->ps_processing && time_before(jiffies, timeout))

		msleep(10);



	/* System suspend is not allowed to wakeup */

	while (pwrpriv->bInSuspend && time_before(jiffies, timeout))

		msleep(10);



	/* I think this should be check in IPS, LPS, autosuspend functions... */

	if (check_fwstate(pmlmepriv, _FW_LINKED)) {

		ret = _SUCCESS;