Unverified Commit b09313dd authored by Andrew Jones's avatar Andrew Jones Committed by Palmer Dabbelt
Browse files

RISC-V: hwprobe: Explicity check for -1 in vdso init 



id_bitsmash is unsigned. We need to explicitly check for -1, rather
than use > 0.

Fixes: aa5af0aa ("RISC-V: Add hwprobe vDSO function and data")
Signed-off-by: default avatarAndrew Jones <ajones@ventanamicro.com>
Reviewed-by: default avatarConor Dooley <conor.dooley@microchip.com>
Reviewed-by: default avatarEvan Green <evan@rivosinc.com>
Link: https://lore.kernel.org/r/20230426141333.10063-3-ajones@ventanamicro.com


Signed-off-by: default avatarPalmer Dabbelt <palmer@rivosinc.com>
parent 08dc1075

arch/riscv/kernel/sys_riscv.c

+1 −1
Original line number Diff line number Diff line
@@ -282,7 +282,7 @@ static int __init init_hwprobe_vdso_data(void) 
	 * populated) or any value returns -1 (varies across CPUs), then the

	 * vDSO should defer to the kernel for exotic cpu masks.

	 */

	avd->homogeneous_cpus = (id_bitsmash > 0);

	avd->homogeneous_cpus = id_bitsmash != 0 && id_bitsmash != -1;

	return 0;

}