Commit b069e14f authored by Paul Blakey's avatar Paul Blakey Committed by Saeed Mahameed
Browse files

net/mlx5e: CT: Fix queued up restore put() executing after relevant ft release 



__mlx5_tc_ct_entry_put() queues release of tuple related to some ct FT,
if that is the last reference to that tuple, the actual deletion of
the tuple can happen after the FT is already destroyed and freed.

Flush the used workqueue before destroying the ct FT.

Fixes: a2173131 ("net/mlx5e: CT: manage the lifetime of the ct entry object")
Reviewed-by: default avatarOz Shlomo <ozsh@nvidia.com>
Signed-off-by: default avatarPaul Blakey <paulb@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent e3fdc71b

drivers/net/ethernet/mellanox/mlx5/core/en/tc_ct.c

+4 −0
Original line number Diff line number Diff line
@@ -1741,6 +1741,8 @@ mlx5_tc_ct_flush_ft_entry(void *ptr, void *arg) 
static void

mlx5_tc_ct_del_ft_cb(struct mlx5_tc_ct_priv *ct_priv, struct mlx5_ct_ft *ft)

{

	struct mlx5e_priv *priv;



	if (!refcount_dec_and_test(&ft->refcount))

		return;
@@ -1750,6 +1752,8 @@ mlx5_tc_ct_del_ft_cb(struct mlx5_tc_ct_priv *ct_priv, struct mlx5_ct_ft *ft) 
	rhashtable_free_and_destroy(&ft->ct_entries_ht,

				    mlx5_tc_ct_flush_ft_entry,

				    ct_priv);

	priv = netdev_priv(ct_priv->netdev);

	flush_workqueue(priv->wq);

	mlx5_tc_ct_free_pre_ct_tables(ft);

	mapping_remove(ct_priv->zone_mapping, ft->zone_restore_id);

	kfree(ft);