Commit b063b192 authored by Andrew Lunn's avatar Andrew Lunn Committed by Jakub Kicinski
Browse files

net: mdio: C22 is now optional, EOPNOTSUPP if not provided 



When performing a C22 operation, check that the bus driver actually
provides the methods, and return -EOPNOTSUPP if not. C45 only busses
do exist, and in future their C22 methods will be NULL.

Signed-off-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarMichael Walle <michael@walle.cc>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 555d64c6

drivers/net/phy/mdio_bus.c

+8 −2
Original line number Diff line number Diff line
@@ -766,7 +766,10 @@ int __mdiobus_read(struct mii_bus *bus, int addr, u32 regnum) 


	lockdep_assert_held_once(&bus->mdio_lock);



	if (bus->read)

		retval = bus->read(bus, addr, regnum);

	else

		retval = -EOPNOTSUPP;



	trace_mdio_access(bus, 1, addr, regnum, retval, retval);

	mdiobus_stats_acct(&bus->stats[addr], true, retval);
@@ -792,7 +795,10 @@ int __mdiobus_write(struct mii_bus *bus, int addr, u32 regnum, u16 val) 


	lockdep_assert_held_once(&bus->mdio_lock);



	if (bus->write)

		err = bus->write(bus, addr, regnum, val);

	else

		err = -EOPNOTSUPP;



	trace_mdio_access(bus, 0, addr, regnum, val, err);

	mdiobus_stats_acct(&bus->stats[addr], false, err);