Commit b05f30bc authored by Jingbo Xu's avatar Jingbo Xu Committed by Gao Xiang
Browse files

erofs: simplify erofs_xattr_generic_get() 



erofs_xattr_generic_get() won't be called from xattr handlers other than
user/trusted/security xattr handler, and thus there's no need of extra
checking.

Signed-off-by: default avatarJingbo Xu <jefflexu@linux.alibaba.com>
Link: https://lore.kernel.org/r/20230330082910.125374-4-jefflexu@linux.alibaba.com


Reviewed-by: default avatarGao Xiang <hsiangkao@linux.alibaba.com>
Reviewed-by: default avatarYue Hu <huyue2@coolpad.com>
Reviewed-by: default avatarChao Yu <chao@kernel.org>
Signed-off-by: default avatarGao Xiang <hsiangkao@linux.alibaba.com>
parent 6020ffe7

fs/erofs/xattr.c

+3 −14
Original line number Diff line number Diff line
@@ -432,20 +432,9 @@ static int erofs_xattr_generic_get(const struct xattr_handler *handler, 
				   struct dentry *unused, struct inode *inode,

				   const char *name, void *buffer, size_t size)

{

	struct erofs_sb_info *const sbi = EROFS_I_SB(inode);



	switch (handler->flags) {

	case EROFS_XATTR_INDEX_USER:

		if (!test_opt(&sbi->opt, XATTR_USER))

	if (handler->flags == EROFS_XATTR_INDEX_USER &&

	    !test_opt(&EROFS_I_SB(inode)->opt, XATTR_USER))

		return -EOPNOTSUPP;

		break;

	case EROFS_XATTR_INDEX_TRUSTED:

		break;

	case EROFS_XATTR_INDEX_SECURITY:

		break;

	default:

		return -EINVAL;

	}



	return erofs_getxattr(inode, handler->flags, name, buffer, size);

}