Commit b03db23a authored Jul 02, 2024 by Igor Pylypiv Committed by Wen Zhiwei Oct 22, 2024

ata: libata-scsi: Remove redundant sense_buffer memsets

stable inclusion
from stable-v6.6.51
commit c8d4acb325302fd832e10d5ba17b1b8eba9d08f9
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/IAYRVR

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=c8d4acb325302fd832e10d5ba17b1b8eba9d08f9



--------------------------------

[ Upstream commit 3f6d903b54a137e9e438d9c3b774b5d0432917bc ]

SCSI layer clears sense_buffer in scsi_queue_rq() so there is no need for
libata to clear it again.

Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Niklas Cassel <cassel@kernel.org>
Signed-off-by: Igor Pylypiv <ipylypiv@google.com>
Link: https://lore.kernel.org/r/20240702024735.1152293-5-ipylypiv@google.com


Signed-off-by: Niklas Cassel <cassel@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Wen Zhiwei <wenzhiwei@kylinos.cn>

parent a1301e48

drivers/ata/libata-scsi.c

+0 −5

Original line number	Diff line number	Diff line
		@@ -926,11 +926,8 @@ static void ata_gen_passthru_sense(struct ata_queued_cmd *qc)
		{
		struct scsi_cmnd *cmd = qc->scsicmd;
		struct ata_taskfile *tf = &qc->result_tf;
		unsigned char *sb = cmd->sense_buffer;
		u8 sense_key, asc, ascq;

		memset(sb, 0, SCSI_SENSE_BUFFERSIZE);

		/*
		* Use ata_to_sense_error() to map status register bits
		* onto sense key, asc & ascq.
		@@ -976,8 +973,6 @@ static void ata_gen_ata_sense(struct ata_queued_cmd *qc)
		u64 block;
		u8 sense_key, asc, ascq;

		memset(sb, 0, SCSI_SENSE_BUFFERSIZE);

		if (ata_dev_disabled(dev)) {
		/* Device disabled after error recovery */
		/* LOGICAL UNIT NOT READY, HARD RESET REQUIRED */