Commit b02bb79e authored by Chengfeng Ye's avatar Chengfeng Ye Committed by Corey Minyard
Browse files

ipmi: fix potential deadlock on &kcs_bmc->lock 



As kcs_bmc_handle_event() is executed inside both a timer and a hardirq,
it should disable irq before lock acquisition otherwise deadlock could
happen if the timmer is preemtped by the irq.

Possible deadlock scenario:
aspeed_kcs_check_obe() (timer)
    -> kcs_bmc_handle_event()
    -> spin_lock(&kcs_bmc->lock)
        <irq interruption>
        -> aspeed_kcs_irq()
        -> kcs_bmc_handle_event()
        -> spin_lock(&kcs_bmc->lock) (deadlock here)

This flaw was found using an experimental static analysis tool we are
developing for irq-related deadlock.

The tentative patch fix the potential deadlock by spin_lock_irqsave()

Signed-off-by: default avatarChengfeng Ye <dg573847474@gmail.com>
Message-Id: <20230627152449.36093-1-dg573847474@gmail.com>
Signed-off-by: default avatarCorey Minyard <minyard@acm.org>
parent 6cf1a126

drivers/char/ipmi/kcs_bmc.c

+3 −2
Original line number Diff line number Diff line
@@ -56,12 +56,13 @@ irqreturn_t kcs_bmc_handle_event(struct kcs_bmc_device *kcs_bmc) 
{

	struct kcs_bmc_client *client;

	irqreturn_t rc = IRQ_NONE;

	unsigned long flags;



	spin_lock(&kcs_bmc->lock);

	spin_lock_irqsave(&kcs_bmc->lock, flags);

	client = kcs_bmc->client;

	if (client)

		rc = client->ops->event(client);

	spin_unlock(&kcs_bmc->lock);

	spin_unlock_irqrestore(&kcs_bmc->lock, flags);



	return rc;

}