Commit b02ba9ed authored by John Harrison's avatar John Harrison
Browse files

drm/i915/uc: Rationalise delimiters in filename macros 



The way delimiters (underscores and dots) were added to the UC
filenames was different for different types of delimiter. Rationalise
them to all be done the same way - implicitly in the concatenation
macro rather than explicitly in the file name prefix.

Signed-off-by: default avatarJohn Harrison <John.C.Harrison@Intel.com>
Reviewed-by: default avatarDaniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20221129232031.3401386-2-John.C.Harrison@Intel.com
parent 4186e218

drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c

+8 −8
Original line number Diff line number Diff line
@@ -118,35 +118,35 @@ void intel_uc_fw_change_status(struct intel_uc_fw *uc_fw, 
 */

#define __MAKE_UC_FW_PATH_BLANK(prefix_, name_) \

	"i915/" \

	__stringify(prefix_) name_ ".bin"

	__stringify(prefix_) "_" name_ ".bin"



#define __MAKE_UC_FW_PATH_MAJOR(prefix_, name_, major_) \

	"i915/" \

	__stringify(prefix_) name_ \

	__stringify(prefix_) "_" name_ "_" \

	__stringify(major_) ".bin"



#define __MAKE_UC_FW_PATH_MMP(prefix_, name_, major_, minor_, patch_) \

	"i915/" \

	__stringify(prefix_) name_ \

	__stringify(prefix_) "_" name_  "_" \

	__stringify(major_) "." \

	__stringify(minor_) "." \

	__stringify(patch_) ".bin"



/* Minor for internal driver use, not part of file name */

#define MAKE_GUC_FW_PATH_MAJOR(prefix_, major_, minor_) \

	__MAKE_UC_FW_PATH_MAJOR(prefix_, "_guc_", major_)

	__MAKE_UC_FW_PATH_MAJOR(prefix_, "guc", major_)



#define MAKE_GUC_FW_PATH_MMP(prefix_, major_, minor_, patch_) \

	__MAKE_UC_FW_PATH_MMP(prefix_, "_guc_", major_, minor_, patch_)

	__MAKE_UC_FW_PATH_MMP(prefix_, "guc", major_, minor_, patch_)



#define MAKE_HUC_FW_PATH_BLANK(prefix_) \

	__MAKE_UC_FW_PATH_BLANK(prefix_, "_huc")

	__MAKE_UC_FW_PATH_BLANK(prefix_, "huc")



#define MAKE_HUC_FW_PATH_GSC(prefix_) \

	__MAKE_UC_FW_PATH_BLANK(prefix_, "_huc_gsc")

	__MAKE_UC_FW_PATH_BLANK(prefix_, "huc_gsc")



#define MAKE_HUC_FW_PATH_MMP(prefix_, major_, minor_, patch_) \

	__MAKE_UC_FW_PATH_MMP(prefix_, "_huc_", major_, minor_, patch_)

	__MAKE_UC_FW_PATH_MMP(prefix_, "huc", major_, minor_, patch_)



/*

 * All blobs need to be declared via MODULE_FIRMWARE().